Closed Bug 1750738 Opened 3 years ago Closed 1 year ago

JS debugger: can't remove custom breakpoints added on other page/url

Categories

(DevTools :: Debugger, defect, P2)

Firefox 97
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: antonfedonyuk, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:97.0) Gecko/20100101 Firefox/97.0

Steps to reproduce:

  1. Add breakpoint at changes attributes
  2. Change page and try remove breakpoint

For example, add breakpoint to "button.accordion-button" on page https://getbootstrap.com/docs/5.0/components/accordion/ and go to page
https://getbootstrap.com/docs/5.1/components/accordion/

Actual results:

nothing, breakpoint is not deleted

Expected results:

delete breakpoint

Summary: JS debugger: can't remove custom breakpoints added to other pages/urls → JS debugger: can't remove custom breakpoints added on other page/url
Attached image add breakpoint
Attached image remove breakpoint

The Bugbug bot thinks this bug should belong to the 'DevTools::Debugger' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Debugger
Product: Firefox → DevTools
Status: UNCONFIRMED → NEW
Ever confirmed: true

Bomsy offered to take a look at this, thanks!

Severity: -- → S3
Flags: needinfo?(hmanilla)
Priority: -- → P2

(In reply to Julian Descottes [:jdescottes] from comment #4)

Confirmed, we throw on https://searchfox.org/mozilla-central/rev/c3cbf7e56630d12443459a6bd7938358c231ce3b/devtools/client/framework/actions/dom-mutation-breakpoints.js#57 but we should probably remove DOM breakpoints on will-navigate.

what's about redirects by JS and HTML(<meta http-equiv="refresh" content="1;URL=http://site.com">)?

(In reply to Anton from comment #0)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:97.0) Gecko/20100101 Firefox/97.0

Steps to reproduce:

  1. Add breakpoint at changes attributes
  2. Change page and try remove breakpoint

For example, add breakpoint to "button.accordion-button" on page https://getbootstrap.com/docs/5.0/components/accordion/ and go to page
https://getbootstrap.com/docs/5.1/components/accordion/

Actual results:

nothing, breakpoint is not deleted

Expected results:

delete breakpoint

I can no longer reproduce this issue. Looks like it has been fixed. I tried setting a breakpoint on a js file in https://getbootstrap.com/docs/5.0/components/accordion/ and then on switching to same file in https://getbootstrap.com/docs/5.1/components/accordion/ the breakpoint no longer exists.

Anton,
Can you confirm that this has been fixed for you with the latest firefox? I'll close the issue. Feel free to reopen if it still occurs.

Thanks

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(hmanilla) → needinfo?(antonfedonyuk)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: